Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure storage metricset values not inside the metricset name #21845

Merged
merged 39 commits into from
Oct 20, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Oct 15, 2020

What does this PR do?

Fixes the azure storage metricset event format

Why is it important?

Latest changes on moving metricsets to light ones has caused on issue on the storage metricset where metric values were not inside the storage object

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

narph added 30 commits July 23, 2020 11:01
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 15, 2020
@narph narph self-assigned this Oct 15, 2020
@narph narph added [zube]: In Review needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Oct 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 15, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 15, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21845 updated]

  • Start Time: 2020-10-19T16:04:53.139+0000

  • Duration: 70 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 630
Skipped 48
Total 678

@@ -41,6 +41,8 @@ func New(base mb.BaseMetricSet) (mb.MetricSet, error) {
if err != nil {
return nil, err
}
// set default resource type to indicate this is not the generic monitor metricset
ms.Client.Config.DefaultResourceType = defaultStorageAccountNamespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way we can test this?

Copy link
Contributor Author

@narph narph Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless we change the entire structure of the function and create a mock client etc or having some integration tests in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to those!

@narph narph requested a review from exekias October 19, 2020 12:49
@narph narph merged commit fa50a44 into elastic:master Oct 20, 2020
@narph narph deleted the fix-storage branch October 20, 2020 07:28
narph added a commit to narph/beats that referenced this pull request Oct 20, 2020
…#21845)

* mofidy doc

* fix

* changelog

(cherry picked from commit fa50a44)
narph added a commit to narph/beats that referenced this pull request Oct 20, 2020
…#21845)

* mofidy doc

* fix

* changelog

(cherry picked from commit fa50a44)
narph added a commit that referenced this pull request Oct 20, 2020
…#22004)

* mofidy doc

* fix

* changelog

(cherry picked from commit fa50a44)
narph added a commit that referenced this pull request Oct 20, 2020
…#22005)

* mofidy doc

* fix

* changelog

(cherry picked from commit fa50a44)
v1v added a commit to v1v/beats that referenced this pull request Oct 21, 2020
* upstream/master:
  feat: package aliases for snapshots (elastic#21960)
  [DOC] Add firewall as possible troubleshooting issue (elastic#21743)
  [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993)
  [Elastic Agent] Fix missing elastic_agent event data  (elastic#21994)
  Document auditbeat system process module config (elastic#21766)
  Update links (elastic#22012)
  dynamically find librpm (elastic#21936)
  Fix Istio docs (elastic#22019)
  [beats-tester][packaging] store packages in another location (elastic#21903)
  [Kubernetes] Remove redundant dockersock volume mount (elastic#22009)
  [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951)
  Azure storage metricset values not inside the metricset name (elastic#21845)
  fix diskio and memory bugs under windows (elastic#21992)
  Fix TestDockerStart flaky test (elastic#21681)
  filebeat: add SSL options to checkpoint module (elastic#19560)
  Stop storing stateless kubernetes keystores (elastic#21880)
  [Elastic Agent] Fix named pipe communication on Windows 7 (elastic#21931)
  [Elastic Agent] Fix index for Agent monitoring to to elastic_agent. (elastic#21932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants