Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the url of reviewdog #21981

Merged
merged 1 commit into from
Oct 22, 2020
Merged

fix the url of reviewdog #21981

merged 1 commit into from
Oct 22, 2020

Conversation

shogo82148
Copy link
Contributor

  • Bug

What does this PR do?

Updates the url of reviewdog.

Why is it important?

related to #21976
It looks that Go tries to install the reviewdog from github.com/haya14busa/reviewdog, but the reviewdog was moved to reviewdog organization.
New url of the reviewdog is github.com/reviewdog/reviewdog.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2020
@cla-checker-service
Copy link

cla-checker-service bot commented Oct 19, 2020 •
edited
Loading

💚 CLA has been signed

@shogo82148 shogo82148 mentioned this pull request Oct 19, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 19, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Shaunak Kashyap, Replayed #1]

  • Start Time: 2020-10-20T01:09:01.591+0000

  • Duration: 28 min 0 sec

@ycombinator ycombinator added the Team:Integrations Label for the Integrations team label Oct 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2020
@ycombinator
Copy link
Contributor

Hi @shogo82148, would you mind signing the Elastic Contributor License Agreement (CLA) at https://www.elastic.co/contributor-agreement so we can review your PR? Thanks!

@shogo82148
Copy link
Contributor Author

@ycombinator Sure. I have signed.

jsoriano
jsoriano approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shogo82148!

@jsoriano jsoriano merged commit 215f49c into elastic:master Oct 22, 2020
@jsoriano jsoriano self-assigned this Oct 22, 2020
@jsoriano jsoriano mentioned this pull request Oct 22, 2020
Merged
6 tasks
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Oct 22, 2020
@shogo82148 @jsoriano
Fix the url of reviewdog (elastic#21981)
c434dff 
(cherry picked from commit 215f49c)
@jsoriano jsoriano mentioned this pull request Oct 22, 2020
Merged
6 tasks
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Oct 22, 2020
@shogo82148 @jsoriano
Fix the url of reviewdog (elastic#21981)
7b9e809 
(cherry picked from commit 215f49c)
@jsoriano jsoriano mentioned this pull request Oct 22, 2020
Merged
6 tasks
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Oct 22, 2020
@shogo82148 @jsoriano
Fix the url of reviewdog (elastic#21981)
12d489f 
(cherry picked from commit 215f49c)
@jsoriano jsoriano mentioned this pull request Oct 22, 2020
Merged
6 tasks
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Oct 22, 2020
@shogo82148 @jsoriano
Fix the url of reviewdog (elastic#21981)
2b1c0d6 
(cherry picked from commit 215f49c)
v1v added a commit to v1v/beats that referenced this pull request Oct 22, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/support-b…
5ae1ae8 
…uild-retry-docker-if-error-packaging

* upstream/master:
  Fix the url of reviewdog (elastic#21981)
  revert WSS process reporting for windows (elastic#22055)
  Fix typo (elastic#19585) (elastic#22061)
jsoriano added a commit that referenced this pull request Oct 22, 2020
@jsoriano @shogo82148
Fix the url of reviewdog (#21981) (#22068)
2fdbf89 
(cherry picked from commit 215f49c)

Co-authored-by: Ichinose Shogo <shogo82148@gmail.com>
jsoriano added a commit that referenced this pull request Oct 22, 2020
@jsoriano @shogo82148
Fix the url of reviewdog (#21981) (#22069)
96a51f9 
(cherry picked from commit 215f49c)

Co-authored-by: Ichinose Shogo <shogo82148@gmail.com>
jsoriano added a commit that referenced this pull request Oct 22, 2020
@jsoriano @shogo82148
Fix the url of reviewdog (#21981) (#22070)
61f5b7d 
(cherry picked from commit 215f49c)

Co-authored-by: Ichinose Shogo <shogo82148@gmail.com>
v1v added a commit to v1v/beats that referenced this pull request Oct 22, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2008
2080cc2 
* upstream/master: (27 commits)
  chore: use ubuntu 18 as linux agent (elastic#22084)
  docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075)
  docs: Prepare Changelog for 6.8.13 (elastic#22072) (elastic#22079)
  [build][packaging] Add resilience when docker build (elastic#22050)
  Fix the url of reviewdog (elastic#21981)
  revert WSS process reporting for windows (elastic#22055)
  Fix typo (elastic#19585) (elastic#22061)
  [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884)
  Prevent log input from sending duplicate messages due to file renaming (elastic#21911)
  feat: package aliases for snapshots (elastic#21960)
  [DOC] Add firewall as possible troubleshooting issue (elastic#21743)
  [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993)
  [Elastic Agent] Fix missing elastic_agent event data  (elastic#21994)
  Document auditbeat system process module config (elastic#21766)
  Update links (elastic#22012)
  dynamically find librpm (elastic#21936)
  Fix Istio docs (elastic#22019)
  [beats-tester][packaging] store packages in another location (elastic#21903)
  [Kubernetes] Remove redundant dockersock volume mount (elastic#22009)
  [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951)
  ...
jsoriano added a commit that referenced this pull request Oct 22, 2020
@jsoriano @shogo82148
Cherry-pick #21981 to 6.8: fix the url of reviewdog (#22071)
6741ca1 
* Fix the url of reviewdog (#21981)

(cherry picked from commit 215f49c)

Co-authored-by: Ichinose Shogo <shogo82148@gmail.com>
v1v added a commit to v1v/beats that referenced this pull request Oct 26, 2020
@v1v
Merge branch 'feature/support-flaky-test-analyser' of github.com:v1v/…
290ff18 
…beats into feature/support-flaky-test-analyser

* 'feature/support-flaky-test-analyser' of github.com:v1v/beats: (40 commits)
  [CI] support windows-10 (elastic#19804)
  Use default config when creating the input (elastic#22126)
  Change x509 mappings from file. to tls.server. (elastic#22097)
  Add fleet settings image (elastic#22065)
  Edit 7.9.3 changelog (elastic#22117)
  Edit 6.8.13 release notes (elastic#22120)
  Incorporate librpm fix feedback (elastic#22098)
  [libbeat] Add more disk queue unit tests and fix a size-check bug (elastic#22107)
  docs: move kerberos include (elastic#22109)
  Check context.Canceled and fix s3 input config (elastic#22036)
  Add max_number_of_messages into aws filebeat fileset vars (elastic#22057)
  Remove suricata.eve.timestamp alias (elastic#22095)
  [Ingest Manager] Use symlink path for reexecutions (elastic#21835)
  chore: use ubuntu 18 as linux agent (elastic#22084)
  docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075)
  docs: Prepare Changelog for 6.8.13 (elastic#22072) (elastic#22079)
  [build][packaging] Add resilience when docker build (elastic#22050)
  Fix the url of reviewdog (elastic#21981)
  revert WSS process reporting for windows (elastic#22055)
  Fix typo (elastic#19585) (elastic#22061)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 29, 2020
@v1v
Merge remote-tracking branch 'upstream/6.8' into feature/ci-2.0-6.8
cf4d33b 
* upstream/6.8:
  Edit 6.8.13 release notes (elastic#22108)
  Cherry-pick elastic#21981 to 6.8: fix the url of reviewdog (elastic#22071)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano @shogo82148
Fix the url of reviewdog (elastic#21981) (elastic#22070)
11ee415 
(cherry picked from commit 0ee2343)

Co-authored-by: Ichinose Shogo <shogo82148@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees

@jsoriano jsoriano

Labels
Team:Integrations Label for the Integrations team v6.8.13 v7.9.3 v7.10.0 v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shogo82148 @elasticmachine @ycombinator @jsoriano