Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22009 to 7.9: [Kubernetes] Remove redundant dockersock volume mount #22015

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Oct 20, 2020

Cherry-pick of PR #22009 to 7.9 branch. Original message:

What does this PR do?

Removes redundant dockersock volume mount which is not currently used out-of-the-box since it is only necessesary for add_docker_metadata and docker module which are not enabled by default. An additional reason for removing this is that it can cause problems on k8s deployments that do not use docker as container runtime and hence the socket is missing.

Why is it important?

  1. Clean manifest
  2. Avoid confusion with users running on k8s with runtime other than docker.

@ChrsMark ChrsMark added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Oct 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 20, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22015 opened]

  • Start Time: 2020-10-20T09:53:11.395+0000

  • Duration: 78 min 16 sec

@ChrsMark ChrsMark merged commit f234e2a into elastic:7.9 Oct 20, 2020
@zube zube bot removed the [zube]: Done label Jan 19, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants