Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interval documentation to monitor metricset #22152

Merged
merged 42 commits into from
Oct 29, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Oct 26, 2020

What does this PR do?

Add interval documentation to monitor metricset

Why is it important?

Not confuse users

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

narph added 30 commits July 23, 2020 11:01
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 26, 2020
@narph narph self-assigned this Oct 26, 2020
@narph narph added [zube]: In Review needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Oct 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 26, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 26, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22152 updated]

  • Start Time: 2020-10-29T14:28:45.327+0000

  • Duration: 9 min 10 sec

@elasticmachine
Copy link
Collaborator

❕ Flaky test report

No test was executed to be analysed.

@@ -96,7 +96,7 @@ This metricset will collect metrics from the storage accounts, these metrics wil
so the `period` for `storage` metricset should be `300s` or multiples of `300s`.

[float]
=== `container_instance`
=== `container_instance`a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@narph narph merged commit 231f5ad into elastic:master Oct 29, 2020
@narph narph deleted the azure-doc-period branch October 29, 2020 15:07
v1v added a commit to v1v/beats that referenced this pull request Oct 29, 2020
* upstream/master: (93 commits)
  Update commands used in the quick start (elastic#22248)
  Add interval documentation to `monitor` metricset (elastic#22152)
  [CI] enable x-pack/packetbeat in the CI (elastic#22252)
  Fix awscloudwatch input documentation (elastic#22247)
  Add support for different Azure Cloud environments in the metricbeat azure module (elastic#21044)
  [CI] support windows-2008-r2 (elastic#19791)
  protect against accessing undefined variables in sysmon module (elastic#22236)
  [CI] archive only if failed steps (elastic#22220)
  Add pe fields to Sysmon module (elastic#22217)
  [CI][flaky] Support 7.x branches and PRs (elastic#22197)
  Perfmon - Fix regular expressions to comply to multiple parentheses in instance name and object (elastic#22146)
  ci: improve linting speed (elastic#22103)
  Move cloudfoundry tags with metadata to common metadata fields (elastic#22150)
  [Docs] Update custom beat docs (elastic#22194)
  [Ingest Manager] Agent fix snapshot download for upgrade (elastic#22175)
  Update shared-autodiscover.asciidoc (elastic#21827)
  [DOCS] Warn about compression and Azure Event Hub for Kafka (elastic#21578)
  [CI][flaky] reporting for PRs in GitHub (elastic#21853)
  [Packetbeat] Create x-pack magefile (elastic#21979)
  [Elastic Agent] Fix deb/rpm installation (elastic#22153)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 29, 2020
* upstream/master: (93 commits)
  Update commands used in the quick start (elastic#22248)
  Add interval documentation to `monitor` metricset (elastic#22152)
  [CI] enable x-pack/packetbeat in the CI (elastic#22252)
  Fix awscloudwatch input documentation (elastic#22247)
  Add support for different Azure Cloud environments in the metricbeat azure module (elastic#21044)
  [CI] support windows-2008-r2 (elastic#19791)
  protect against accessing undefined variables in sysmon module (elastic#22236)
  [CI] archive only if failed steps (elastic#22220)
  Add pe fields to Sysmon module (elastic#22217)
  [CI][flaky] Support 7.x branches and PRs (elastic#22197)
  Perfmon - Fix regular expressions to comply to multiple parentheses in instance name and object (elastic#22146)
  ci: improve linting speed (elastic#22103)
  Move cloudfoundry tags with metadata to common metadata fields (elastic#22150)
  [Docs] Update custom beat docs (elastic#22194)
  [Ingest Manager] Agent fix snapshot download for upgrade (elastic#22175)
  Update shared-autodiscover.asciidoc (elastic#21827)
  [DOCS] Warn about compression and Azure Event Hub for Kafka (elastic#21578)
  [CI][flaky] reporting for PRs in GitHub (elastic#21853)
  [Packetbeat] Create x-pack magefile (elastic#21979)
  [Elastic Agent] Fix deb/rpm installation (elastic#22153)
  ...
narph added a commit to narph/beats that referenced this pull request Oct 30, 2020
* mofidy doc

* update doc

* changelog

* space

* updaet

* spelling

(cherry picked from commit 231f5ad)
narph added a commit to narph/beats that referenced this pull request Oct 30, 2020
* mofidy doc

* update doc

* changelog

* space

* updaet

* spelling

(cherry picked from commit 231f5ad)
narph added a commit that referenced this pull request Nov 2, 2020
…etricset (#22294)

* Add interval documentation to `monitor` metricset (#22152)

* mofidy doc

* update doc

* changelog

* space

* updaet

* spelling

(cherry picked from commit 231f5ad)

* fix changelog
narph added a commit that referenced this pull request Nov 2, 2020
…tricset (#22292)

* Add interval documentation to `monitor` metricset (#22152)

* mofidy doc

* update doc

* changelog

* space

* updaet

* spelling

(cherry picked from commit 231f5ad)

* fix changelog
v1v added a commit to v1v/beats that referenced this pull request Nov 2, 2020
* upstream/7.10:
  [CI] Support Windows-8 (elastic#22307) (elastic#22319)
  Cherry-pick elastic#22152 to 7.10: Add interval documentation to `monitor` metricset (elastic#22294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants