[Metricbeat] Remove io.time from windows #22237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
needs_backport
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
The test failure looks related to the change. |
|
Yep, didn't notice it yesterday. Should be fixed. |
kaiyan-sheng
approved these changes
Oct 29, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 30, 2020
* upstream/master: adding timeout options to cisco umbrella and fixing the missing config options in module config.yml (elastic#22295) [Metricbeat] Remove io.time from windows (elastic#22237) remove debug messages (elastic#22282) dependency upgrade: ecszap v0.3.0 (elastic#22267) [repo] Add docs + cleanup labels to the categories in the incoming PR template (elastic#22280)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 30, 2020
* upstream/master: adding timeout options to cisco umbrella and fixing the missing config options in module config.yml (elastic#22295) [Metricbeat] Remove io.time from windows (elastic#22237) remove debug messages (elastic#22282) dependency upgrade: ecszap v0.3.0 (elastic#22267) [repo] Add docs + cleanup labels to the categories in the incoming PR template (elastic#22280)
5 tasks
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Oct 30, 2020
* remove io.time from windows * fix tests * add changelog entry (cherry picked from commit 77882fc)
fearful-symmetry
added
v7.11.0
and removed
needs_backport
5 tasks
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Oct 30, 2020
* remove io.time from windows * fix tests * add changelog entry (cherry picked from commit 77882fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It looks like
diskio.io.timeis a unix-only field that reports an incorrect zero. We accidentally marked it as "no incorrect zero" on our massive spreadsheet of metrics inventory, so it was overlooked until now.Why is it important?
We don't want to report "incorrect zero" metrics.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
diskiometricset and insure thatdiskio.io.timeis not reported.diskio.io.timeis reported.Related issues