Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #22287 to 7.x: Change cloud.provider from googlecloud to gcp in billing metricset #22311

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Cherry-pick #22287 to 7.x: Change cloud.provider from googlecloud to gcp in billing metricset #22311

merged 1 commit into from
Oct 30, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 30, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22287 to 7.x branch. Original message:

This PR is to change cloud.provider from googlecloud to gcp in billing metricset to match the rest of the metricsets under googlecloud module. This is to match the definition of this field in ECS.

The rest of the metricsets under googlecloud module had cloud.provider changed to gcp in #21775.

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Oct 30, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 30, 2020
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 606
Skipped 48
Total 654

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22311 opened]

  • Start Time: 2020-10-30T13:29:45.629+0000

  • Duration: 93 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 606
Skipped 48
Total 654

@kaiyan-sheng kaiyan-sheng merged commit 2b8e230 into elastic:7.x Oct 30, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_22287_7.x branch October 30, 2020 15:44
@zube zube bot removed the [zube]: Done label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @ChrsMark