Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate system.process.cmdline field with process.command_line ECS field name #22325

Merged
merged 7 commits into from
Nov 3, 2020
Merged

Duplicate system.process.cmdline field with process.command_line ECS field name #22325

merged 7 commits into from
Nov 3, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 30, 2020 •
edited
Loading

What does this PR do?

This PR is to migrate system.process.cmdline field to use process.command_line ECS field name instead.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 30, 2020
@kaiyan-sheng kaiyan-sheng added in progress Pull request is currently in progress. needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Oct 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Oct 30, 2020
Closed
1 task
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 30, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2248
Skipped 508
Total 2756

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 30, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22325 updated]

  • Start Time: 2020-11-03T19:22:25.127+0000

  • Duration: 66 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 2248
Skipped 508
Total 2756

@kaiyan-sheng kaiyan-sheng removed the in progress Pull request is currently in progress. label Nov 2, 2020
fearful-symmetry
fearful-symmetry approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait for the tests, otherwise LGTM.

@kaiyan-sheng kaiyan-sheng changed the title Use process.command_line ECS field name for system.process.cmdline field Duplicate system.process.cmdline field with process.command_line ECS field name Nov 3, 2020
@kaiyan-sheng kaiyan-sheng merged commit 52ea483 into elastic:master Nov 3, 2020
@kaiyan-sheng kaiyan-sheng deleted the process_cmd branch November 3, 2020 21:10
@kaiyan-sheng kaiyan-sheng mentioned this pull request Nov 3, 2020
Merged
6 tasks
@kaiyan-sheng kaiyan-sheng added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 3, 2020
kaiyan-sheng added a commit that referenced this pull request Nov 5, 2020
@kaiyan-sheng
Duplicate system.process.cmdline field with process.command_line ECS …
93b4e82 
…field name (#22325) (#22406)

(cherry picked from commit 52ea483)
@Zacqary Zacqary mentioned this pull request Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Team:Platforms Label for the Integrations - Platforms team v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @fearful-symmetry