-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat session ID as a string in system/users #22359
Merged
fearful-symmetry
merged 3 commits into
elastic:master
from
fearful-symmetry:system-users-id-str
Nov 3, 2020
Merged
Treat session ID as a string in system/users #22359
fearful-symmetry
merged 3 commits into
elastic:master
from
fearful-symmetry:system-users-id-str
Nov 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
needs_backport
PR is waiting to be backported to other branches.
Team:Integrations
Label for the Integrations team
labels
Nov 2, 2020
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Nov 2, 2020
kaiyan-sheng
reviewed
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good. Missing changelog?
Collaborator
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kaiyan-sheng
approved these changes
Nov 2, 2020
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng
approved these changes
Nov 2, 2020
3 tasks
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Nov 3, 2020
* treat session ID as a string * add changelog * Update wording on CHANGELOG.next.asciidoc Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> (cherry picked from commit 7826ef6)
fearful-symmetry
added
v7.10.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Nov 3, 2020
3 tasks
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Nov 3, 2020
* treat session ID as a string * add changelog * Update wording on CHANGELOG.next.asciidoc Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> (cherry picked from commit 7826ef6)
fearful-symmetry
added a commit
that referenced
this pull request
Nov 3, 2020
* treat session ID as a string * add changelog * Update wording on CHANGELOG.next.asciidoc Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> (cherry picked from commit 7826ef6)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We should be treating the session ID we get from DBus as a string:
The value seems to be an int 95% of the time, which is why I probably missed this. I'm still not sure under what circumstances we see a character thrown into the Session ID, but it does happen.
Why is it important?
If the Session ID isn't an int, we'll get an error.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
system.users.id
value is a string.