Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Add event.ingested to Netflow module #22412

Merged

Conversation

andrewkroh
Copy link
Member

What does this PR do?

Add event.ingested to the pipeline in the Netflow Filebeat module. It was missed when we updated all modules because there are no automated module tests that ingest flow data (the tests only work with logs).

Why is it important?

For consistency we want every module to add event.ingested.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewkroh andrewkroh added enhancement Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations labels Nov 4, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 4, 2020
Add event.ingested to the pipeline in the Netflow Filebeat module.
@andrewkroh andrewkroh force-pushed the feature/fb/netflow-event-ingested branch from 65b7e24 to 4cd73e4 Compare November 4, 2020 12:38
@andrewkroh andrewkroh marked this pull request as ready for review November 4, 2020 12:38
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1948
Skipped 259
Total 2207

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22412 opened]

  • Start Time: 2020-11-04T12:38:23.224+0000

  • Duration: 47 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 1948
Skipped 259
Total 2207

@andrewkroh andrewkroh merged commit fa9ebaa into elastic:master Nov 5, 2020
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Nov 5, 2020
Add event.ingested to the pipeline in the Netflow Filebeat module.

(cherry picked from commit fa9ebaa)
@andrewkroh andrewkroh added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 5, 2020
andrewkroh added a commit that referenced this pull request Nov 6, 2020
Add event.ingested to the pipeline in the Netflow Filebeat module.

(cherry picked from commit fa9ebaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants