Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ephemeral containers in add_kubernetes_metadata #22439

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Nov 4, 2020

What does this PR do?

Add support for ephemeral containers in add_kubernetes_metadata.

Why is it important?

For consistency with #22389, where support for ephemeral containers is added to autodiscover.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@jsoriano jsoriano added review Team:Platforms Label for the Integrations - Platforms team labels Nov 4, 2020
@jsoriano jsoriano self-assigned this Nov 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 4, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 4, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22439 updated]

  • Start Time: 2020-11-05T16:42:06.086+0000

  • Duration: 70 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 16400
Skipped 1342
Total 17742

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 4, 2020

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16400
Skipped 1342
Total 17742

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.11.0 labels Nov 6, 2020
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jsoriano jsoriano merged commit 92b4e3d into elastic:master Nov 9, 2020
@jsoriano jsoriano deleted the k8s-ephemeral-metadata branch November 9, 2020 13:13
jsoriano added a commit to jsoriano/beats that referenced this pull request Nov 9, 2020
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Nov 9, 2020
jsoriano added a commit that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants