Trim down beat name if it's longer than 15 characters #22550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
needs_backport
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
andresrc
added
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
jsoriano
approved these changes
Nov 16, 2020
4 tasks
fearful-symmetry
added
v7.11.0
and removed
needs_backport
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Nov 17, 2020
* Trim down beat name if it's longer than 15 characters * add OS guard, changelog (cherry picked from commit 82b8372)
fearful-symmetry
added a commit
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a fix for #21297
If a beat name is longer than 15 characters on *nix systems, it won't match the process name found by the libbeat metrics tools, which will cause the beat to bomb out. If the beat name exceeds the name in
/proc/self/comm, then truncate it.Why is it important?
Custom beats with long names can fail.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues