-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix index template loading when the new index is selected #22682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Nov 20, 2020
kvch
added
the
Team:Services
(Deprecated) Label for the former Integrations-Services team
label
Nov 20, 2020
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Nov 20, 2020
Collaborator
kvch
force-pushed
the
fix-filebeat-template-index-load
branch
from
November 23, 2020 15:09
cce08e8
to
6ce09da
Compare
michalpristas
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change looks ok
3 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 24, 2020
) ## What does this PR do? This PR fixes the `setup.template.type` setting. When `index` were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index. ## Why is it important? `setup.template.type=index` was broken. Now it is fixed. ## How to test this PR locally ``` ./filebeat setup --index-management -E setup.template.type=index ``` ## Related issues Closes elastic#22482 (cherry picked from commit 569268d)
kvch
added
v7.11.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Nov 24, 2020
3 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 24, 2020
) This PR fixes the `setup.template.type` setting. When `index` were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index. `setup.template.type=index` was broken. Now it is fixed. ``` ./filebeat setup --index-management -E setup.template.type=index ``` Closes elastic#22482 (cherry picked from commit 569268d)
kvch
added a commit
that referenced
this pull request
Nov 25, 2020
…22742) This PR fixes the `setup.template.type` setting. When `index` were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index. `setup.template.type=index` was broken. Now it is fixed. ``` ./filebeat setup --index-management -E setup.template.type=index ``` Closes #22482 (cherry picked from commit 569268d)
kvch
added a commit
that referenced
this pull request
Nov 25, 2020
…22741) ## What does this PR do? This PR fixes the `setup.template.type` setting. When `index` were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index. ## Why is it important? `setup.template.type=index` was broken. Now it is fixed. ## How to test this PR locally ``` ./filebeat setup --index-management -E setup.template.type=index ``` ## Related issues Closes #22482 (cherry picked from commit 569268d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the
setup.template.type
setting. Whenindex
were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index.Why is it important?
setup.template.type=index
was broken. Now it is fixed.Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Related issues
Closes #22482