-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect OneMineRate metrics in Kafka module #22733
Collect OneMineRate metrics in Kafka module #22733
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Test | Results |
---|---|
Failed | 0 |
Passed | 2312 |
Skipped | 510 |
Total | 2822 |
Pinging @elastic/integrations-services (Team:Services) |
@jsoriano can you take a look? would this be a breaking change? |
Sure, taking a look. Generally speaking it would be a breaking change, but I agree that current behaviour is not very useful, so it can be considered more a bugfix. Also this metricset is in beta state, so no problem with this change. @gquintana thanks a lot of this PR! Could you please add a changelog entry in |
jenkins run the tests please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM, waiting for the changelog and CI and it would be ready to merge. Thanks!
jenkins run the tests please |
thanks @jsoriano for the changelog, you were faster than me |
MeanRate is rate an average rate since Kafka startup, it doesn't mean anything and doesn't shown Kafka current state. OneMinuteRate is a better representation of current state. (cherry picked from commit 08a7586)
MeanRate is rate an average rate since Kafka startup, it doesn't mean anything and doesn't shown Kafka current state. OneMinuteRate is a better representation of current state. (cherry picked from commit 08a7586) Co-authored-by: Gerald Quintana <gerald.quintana@gmail.com>
What does this PR do?
Collect OneMinuteRate metrics in Kafka broker metricset instead of MeanRate
Why is it important?
MeanRate is rate an average rate since Kafka startup.
In short it doesn't mean anything and doesn't shown Kafka current state.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Use cases
Kafka monitoring