Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add awsfargate overview dashboard #22745

Closed
wants to merge 5 commits into from
Closed

Add awsfargate overview dashboard #22745

wants to merge 5 commits into from

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Nov 24, 2020 •
edited
Loading

What does this PR do?

This PR is to add an overview dashboard for AWS Fargate.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

Screen Shot 2020-11-24 at 4 04 57 PM (2)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 24, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Nov 24, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Nov 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 24, 2020
This was referenced Nov 24, 2020
Merged
Merged
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 25, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22745 updated

  • Start Time: 2020-12-04T02:59:14.634+0000

  • Duration: 53 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 2696
Skipped 593
Total 3289

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2696
Skipped 593
Total 3289

ChrsMark
ChrsMark reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just 2 comments:

  1. I find it difficult to understand the meaning of Tasks and containers pie chart. Is there anything missing?
  2. Nit: maybe we could also have a screenshot with populated Diskio Visualisation for better user experience.

x-pack/metricbeat/module/awsfargate/cloudformation.yml Outdated Show resolved Hide resolved
@kaiyan-sheng
Copy link
Contributor Author

Need the awsfargate identifier field for dashboard so closing this one and move dashboard over to #22941

@kaiyan-sheng kaiyan-sheng deleted the awsfargate_dashboard branch December 8, 2020 17:57
@kaiyan-sheng kaiyan-sheng removed the needs_backport PR is waiting to be backported to other branches. label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark left review comments

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @ChrsMark