Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22721 to 7.10: Drop pkt_dstaddr and pkt_srcaddr when equals to "-" #22825

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Dec 1, 2020

Cherry-pick of PR #22721 to 7.10 branch. Original message:

What does this PR do?

This PR is to fix parsing error for vpcflow fileset when aws.vpcflow.pkt_dstaddr or aws.vpcflow.pkt_srcaddr equals to -.

Error message:

failed to parse field [aws.vpcflow.pkt_srcaddr] of type [ip] in document with id '229a9b7009-000001896666'. Preview of field's value: '-'

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

* Add painless script to remove all empty fields

(cherry picked from commit 24a4da8)
@ChrsMark ChrsMark added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Dec 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 1, 2020
@@ -198,6 +198,10 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Fix syslog RFC 5424 parsing in the CheckPoint module. {pull}21854[21854]
- Fix incorrect connection state mapping in zeek connection pipeline. {pull}22151[22151] {issue}22149[22149]
- Fix missing variable when loading aws pipelines. {pull}22645[22645]
- Fix handing missing eventtime and assignip field being set to N/A for fortinet module. {pull}22361[22361]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops extra lines 😬

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 1, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22825 updated

  • Start Time: 2020-12-01T15:39:42.173+0000

  • Duration: 48 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 1948
Skipped 259
Total 2207

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1948
Skipped 259
Total 2207

@kaiyan-sheng kaiyan-sheng merged commit 8c98036 into elastic:7.10 Dec 1, 2020
@zube zube bot removed the [zube]: Done label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants