-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Use egress/ingress instead of inbound/outbound for system/socket metricset #22992
[Metricbeat] Use egress/ingress instead of inbound/outbound for system/socket metricset #22992
Conversation
…m/socket metricset
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Test | Results |
---|---|
Failed | 0 |
Passed | 2321 |
Skipped | 523 |
Total | 2844 |
Pinging @elastic/integrations (Team:Integrations) |
Do we need to make this breaking change at this point? |
I guess that @elastic/security-external-integrations are the main users of this field, and this change has been already applied in Winlogbeat #22997 and Auditbeat #22991, so it is probably better to keep consistency on these values. In any case, @andrewstucki could you please confirm that it is desired to do this breaking change in 7.x? |
@jsoriano -- yep, we decided to do the breaking change as part of the ECS 1.7 upgrade. With the clarification/introduction of the Since the addition of those two values was essentially a breaking change in ECS itself (or at least our previous interpretation of it), we are making these breaking changes while upgrading. |
…m/socket metricset (elastic#22992) * [Metricbeat] Use egress/ingress instead of inbound/outbound for system/socket metricset * Add changelog * Fix stray deletion (cherry picked from commit 65e5908)
What does this PR do?
This changes the
system/socket
metricset to use the new ECS 1.7 host-centric ingress/egress values.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues