[Filebeat] panos config option to set internal/external zones #22998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- default internal zone is "trust" - default external zone is "untrust" - allows for user to define zones for determining network.direction Relates elastic#21674
botelastic
bot
added
the
needs_team
leehinman
added
enhancement
Filebeat
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
andrewkroh
approved these changes
Dec 9, 2020
CHANGELOG.next.asciidoc
Outdated
| @@ -738,6 +738,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Add support for UNIX datagram sockets in `unix` input. {issues}18632[18632] {pull}22699[22699] | |||
| - Add new httpjson input features and mark old config ones for deprecation {pull}22320[22320] | |||
| - Add logic for external network.direction in sophos xg fileset {pull}22973[22973] | |||
| - Add configuration option to set external and internal networks for panw panos fileset {pull}XXXXX[XXXXX] | |||
There was a problem hiding this comment.
Suggested change
| - Add configuration option to set external and internal networks for panw panos fileset {pull}XXXXX[XXXXX] | |
| - Add configuration option to set external and internal networks for panw panos fileset {pull}22998[22998] |
| @@ -134,24 +134,23 @@ processors: | |||
| - set: | |||
| field: network.direction | |||
| value: inbound | |||
| if: 'ctx?.panw?.panos?.type == "TRAFFIC" && ctx?.panw?.panos?.source?.zone == "untrust" && ctx?.panw?.panos?.destination?.zone == "trust"' | |||
| if: 'ctx?.panw?.panos?.type == "TRAFFIC" && ctx?._temp_?.external_zones != null && ctx?._temp_?.internal_zones != null && ctx?.observer?.ingress?.zone != null && ctx?.observer?.egress?.zone != null && ctx._temp_.external_zones.contains(ctx.observer.ingress.zone) && ctx._temp_.internal_zones.contains(ctx.observer.egress.zone)' | |||
There was a problem hiding this comment.
That's a lot to take in, but it looks right. I found it easier to read like this since I can see all the logic at once.
Suggested change
| if: 'ctx?.panw?.panos?.type == "TRAFFIC" && ctx?._temp_?.external_zones != null && ctx?._temp_?.internal_zones != null && ctx?.observer?.ingress?.zone != null && ctx?.observer?.egress?.zone != null && ctx._temp_.external_zones.contains(ctx.observer.ingress.zone) && ctx._temp_.internal_zones.contains(ctx.observer.egress.zone)' | |
| if: > | |
| ctx?.panw?.panos?.type == "TRAFFIC" && | |
| ctx?._temp_?.external_zones != null && | |
| ctx?._temp_?.internal_zones != null && | |
| ctx?.observer?.ingress?.zone != null && | |
| ctx?.observer?.egress?.zone != null && | |
| ctx._temp_.external_zones.contains(ctx.observer.ingress.zone) && | |
| ctx._temp_.internal_zones.contains(ctx.observer.egress.zone) |
There was a problem hiding this comment.
yeah those were awful, see if the new formatting is easier on the eyes.
andrewkroh
approved these changes
Dec 9, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Merged
5 tasks
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Dec 9, 2020
…c#22998) * panos config option to set internal/external zones - default internal zone is "trust" - default external zone is "untrust" - allows for user to define zones for determining network.direction Relates elastic#21674 (cherry picked from commit 7b7bbe9)
leehinman
added
v7.11.0
and removed
needs_backport
This was referenced Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds configuration option to set internal and external zones.
Why is it important?
internal and external zones are used to determine network.direction.
Previously static values of "trust" and "untrust" were used, but the
zone names can be controlled by the user.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areasCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues