Allow node/namespace metadata to be disabled on kubernetes metagen and ensure add_kubernetes_metadata honors host #23012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
vjsamuel
force-pushed
the
allow_meta_disable
branch
from
b9c5063
to
328e85c
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 17462 |
| Skipped | 1379 |
| Total | 18841 |
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
vjsamuel
force-pushed
the
allow_meta_disable
branch
from
328e85c
to
9747ffb
Compare
vjsamuel
changed the title
ChrsMark
approved these changes
Dec 14, 2020
ChrsMark
added
v7.11.0
needs_backport
vjsamuel
force-pushed
the
allow_meta_disable
branch
from
9747ffb
to
bcee54c
Compare
6 tasks
ChrsMark
pushed a commit
to ChrsMark/beats
that referenced
this pull request
Dec 14, 2020
…d ensure add_kubernetes_metadata honors host (elastic#23012) (cherry picked from commit 20c7da2)
ChrsMark
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There can always be reason to disable additional metadata. Having flexibility is nice to have. https://github.com/elastic/beats/pull/22189/files#diff-795a7b218ad6ff27d43bc453ecce7984c3d816537b1afc9cfc9000d5d574119eR181 introduced an issue of pulling all node metadata even if running on a daemonset. This PR fixes that behavior
Why is it important?
we dont see the need for each metric to have all labels when being ingested. the lack of node name being passed ot the node watcher causes too much churn on the API server on large clusters.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist