Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Migrate m365_defender to httpjson v2 #23018

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 9, 2020

What does this PR do?

Uses httpjson v2 for m365 defender

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation

  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr added enhancement needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations labels Dec 9, 2020
@marc-gr marc-gr requested a review from P1llus December 9, 2020 11:29
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 9, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23018 updated

  • Start Time: 2020-12-10T10:30:55.614+0000

  • Duration: 45 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 2422
Skipped 261
Total 2683

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2422
Skipped 261
Total 2683

@marc-gr marc-gr force-pushed the migration_m365_httpjsonv2 branch 2 times, most recently from b8f79f2 to 79ca930 Compare December 9, 2020 14:57
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr force-pushed the migration_m365_httpjsonv2 branch 2 times, most recently from d6fd059 to 652a758 Compare December 10, 2020 10:18
@marc-gr marc-gr merged commit de07509 into elastic:master Dec 10, 2020
@marc-gr marc-gr deleted the migration_m365_httpjsonv2 branch December 10, 2020 11:32
@marc-gr marc-gr added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 10, 2020
marc-gr added a commit to marc-gr/beats that referenced this pull request Dec 11, 2020
marc-gr added a commit that referenced this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants