Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to move IIS to GA #23024

Merged
merged 6 commits into from
Dec 10, 2020
Merged

Support to move IIS to GA #23024

merged 6 commits into from
Dec 10, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Dec 9, 2020 •
edited
Loading

What does this PR do?

Maps fields
Sets module and metricsets to GA

Why is it important?

Sets module and metricsets to GA

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2020
@narph narph self-assigned this Dec 9, 2020
@narph narph added [zube]: In Review needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Dec 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 9, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23024 updated

  • Start Time: 2020-12-10T14:35:29.093+0000

  • Duration: 57 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 2704
Skipped 594
Total 3298

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2704
Skipped 594
Total 3298

@jsoriano jsoriano self-requested a review December 10, 2020 11:16
@narph narph requested a review from jsoriano December 10, 2020 13:25
jsoriano
jsoriano approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking comments in some descriptions, but LGTM. Thanks!

x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml Outdated
- name: finallys_per_sec
type: float
description: >
The nr of finallys per sec.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit.

Suggested change
The nr of finallys per sec.
The number of finallys per sec.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml Outdated
- name: net_clr
type: group
description: >
net clr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an obscure description still here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added description to all the group fields, I missed those fields somehow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

x-pack/metricbeat/module/iis/application_pool/_meta/fields.yml Outdated
@@ -1,10 +1,72 @@
- name: application_pool
type: group
release: beta
release: ga
description: >
application_pool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve this description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

jsoriano
jsoriano approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@narph narph merged commit 65c9928 into elastic:master Dec 10, 2020
@narph narph deleted the iis-ga branch December 10, 2020 15:34
@narph narph mentioned this pull request Dec 10, 2020
Merged
6 tasks
@narph narph added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 10, 2020
narph added a commit to narph/beats that referenced this pull request Dec 10, 2020
@narph
Support to move IIS to GA (elastic#23024)
615a5c1 
* iis to GA

* changelog

* update info

* update description

* generate

(cherry picked from commit 65c9928)
narph added a commit that referenced this pull request Dec 11, 2020
@narph
Support to move IIS to GA (#23024) (#23071)
800e0e0 
* iis to GA

* changelog

* update info

* update description

* generate

(cherry picked from commit 65c9928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@narph narph

Labels
Team:Platforms Label for the Integrations - Platforms team v7.11.0 [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map all fields inside the IIS module
3 participants
@narph @elasticmachine @jsoriano