Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22941 to 7.x: Add clusterName, taskName, cloud.region and dashboard to aws fargate #23026

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 9, 2020

Cherry-pick of PR #22941 to 7.x branch. Original message:

What does this PR do?

This PR is to add extra fields for cluster name, task name, cloud region and an identifier for AWS fargate.

Why is it important?

When creating AWS Fargate tasks with the same container/container name, Kibana dashboard get confused and only displaying part of the data. I would like to introduce an awsfargate.identifier = containerName + "/" + containerID to make sure we can distinguish containers from different task or cluster.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshot

metricbeat-awsfargate-overview

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Dec 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 9, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23026 opened

  • Start Time: 2020-12-09T15:14:38.228+0000

  • Duration: 55 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 2702
Skipped 596
Total 3298

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 16 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2702
Skipped 596
Total 3298

@kaiyan-sheng kaiyan-sheng merged commit a6fb530 into elastic:7.x Dec 9, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_22941_7.x branch December 9, 2020 20:05
@zube zube bot removed the [zube]: Done label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants