Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Use ingress/egress for crowdstrike and auditd modules #23041

Merged

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Dec 9, 2020

What does this PR do?

This changes the crowdstrike module to use ingress/egress and adds a bit of functionality into the auditd module to set network.direction by syscall. Since they're both modeling host-oriented data, updated both of them to use ingress/egress.

Interestingly enough, I took a look at some of the pipeline and there are a bunch of cases where we have conditionals that try and categorize syscalls by name, but we don't have any name resolution in the pipeline, so I don't think that they actually work normally. I can create an issue to add resolution based off of the syscall number.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 9, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23041 updated

  • Start Time: 2020-12-09T22:21:05.467+0000

  • Duration: 53 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 5095
Skipped 570
Total 5665

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 5095
Skipped 570
Total 5665

@andrewstucki andrewstucki merged commit 9c89eff into elastic:master Dec 10, 2020
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Dec 10, 2020
…stic#23041)

* [Filebeat] Use ingress/egress for crowdstrike and auditd modules

* Add changelog entry

(cherry picked from commit 9c89eff)
andrewstucki pushed a commit that referenced this pull request Dec 10, 2020
…ike and auditd modules (#23049)

* [Filebeat] Use ingress/egress for crowdstrike and auditd modules (#23041)

* [Filebeat] Use ingress/egress for crowdstrike and auditd modules

* Add changelog entry

(cherry picked from commit 9c89eff)

* Fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants