Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Generate fields for x-pack heartbeat as well #23111

Merged
merged 2 commits into from
Dec 14, 2020
Merged

[Heartbeat] Generate fields for x-pack heartbeat as well #23111

merged 2 commits into from
Dec 14, 2020

Conversation

andrewvc
Copy link
Contributor

Fixes a bug introduced in #21874 where fields.yml generation in x-pack stopped happening.

@andrewvc
[Heartbeat] Generate fields for x-pack heartbeat as well
b4d9ebe 
Fixes a bug introduced in elastic#21874
where fields.yml generation in x-pack stopped happening.
@andrewvc andrewvc added the bug label Dec 14, 2020
@andrewvc andrewvc requested a review from a team as a code owner December 14, 2020 16:27
@andrewvc andrewvc self-assigned this Dec 14, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 14, 2020
@andrewvc andrewvc added v7.11.0 Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 14, 2020
@jsoriano
Copy link
Member

/packaging

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 14, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23111 updated

  • Start Time: 2020-12-14T18:29:53.573+0000

  • Duration: 21 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 932
Skipped 13
Total 945

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 932
Skipped 13
Total 945

@jsoriano
Copy link
Member

/package

@jsoriano jsoriano added the needs_backport PR is waiting to be backported to other branches. label Dec 14, 2020
@jsoriano jsoriano mentioned this pull request Dec 14, 2020
Merged
@andrewvc andrewvc merged commit 78a8625 into elastic:master Dec 14, 2020
@andrewvc andrewvc deleted the fix-x-pack-fields-gen branch December 14, 2020 19:35
andrewvc added a commit to andrewvc/beats that referenced this pull request Dec 14, 2020
@andrewvc
[Heartbeat] Generate fields for x-pack heartbeat as well (elastic#23111)
c045108 
Fixes a bug introduced in elastic#21874
where fields.yml generation in x-pack stopped happening.

(cherry picked from commit 78a8625)
@andrewvc andrewvc mentioned this pull request Dec 14, 2020
Merged
@andrewvc andrewvc removed the needs_backport PR is waiting to be backported to other branches. label Dec 14, 2020
andrewvc added a commit that referenced this pull request Dec 14, 2020
@andrewvc
[Heartbeat] Generate fields for x-pack heartbeat as well (#23111) (#2…
7eb0e8c 
…3122)

Fixes a bug introduced in #21874
where fields.yml generation in x-pack stopped happening.

(cherry picked from commit 78a8625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees

@andrewvc andrewvc

Labels
bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewvc @elasticmachine @jsoriano