[Filebeat] fix organization and customer prefix for aws/cloudtrail #23126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use ^.*AWSLogs as beginning of prefix, matches: + custom-prefix/AWSLogs/1234567890/CloudTrail/ + o-xxxxxxx/AWSLogs/1234567890/CloudTrail/ + AWSLogs/1234567890/CloudTrail/ Closes elastic#23109
botelastic
bot
added
the
needs_team
leehinman
added
bug
Filebeat
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
andrewkroh
reviewed
Dec 15, 2020
andrewkroh
approved these changes
Dec 15, 2020
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Dec 15, 2020
…lastic#23126) * fix organization and customer prefix for aws/cloudtrail - use ^.*AWSLogs as beginning of prefix, matches: + custom-prefix/AWSLogs/1234567890/CloudTrail/ + o-xxxxxxx/AWSLogs/1234567890/CloudTrail/ + AWSLogs/1234567890/CloudTrail/ Closes elastic#23109 Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit b4aba8e)
leehinman
added
v7.11.0
and removed
needs_backport
leehinman
added a commit
that referenced
this pull request
Dec 15, 2020
…23126) (#23138) * fix organization and customer prefix for aws/cloudtrail - use ^.*AWSLogs as beginning of prefix, matches: + custom-prefix/AWSLogs/1234567890/CloudTrail/ + o-xxxxxxx/AWSLogs/1234567890/CloudTrail/ + AWSLogs/1234567890/CloudTrail/ Closes #23109 Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit b4aba8e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes regex used to detect CloudTrail logs from "^AWSLogs" to "^.*AWSLogs".
Why is it important?
AWS CloudTrail allows you define a custom prefix and uses a standard
prefix for organizations. This change matches those conditions
automatically.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Setup CloudTrail with a custom prefix
Related issues