Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22966 to 7.x: [Filebeat] Fix dissect pattern for Cisco WebVPN message 716002 #23131

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Dec 15, 2020

Cherry-pick of PR #22966 to 7.x branch. Original message:

What does this PR do?

The message can contain one of several session termination reasons so don't hardcode "User requested" into the pattern.

Reference: https://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslogs8.html#con_4776918

Why is it important?

The module was failing to parse some WebVPN log messages.

Checklist

  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…ic#22966)

The message can contain one of several session termination reasons so don't hardcode "User requested" into the pattern.

Reference: https://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslogs8.html#con_4776918
(cherry picked from commit 6955f81)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 15, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23131 opened

  • Start Time: 2020-12-15T01:56:15.806+0000

  • Duration: 42 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 2417
Skipped 261
Total 2678

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2417
Skipped 261
Total 2678

@andrewkroh andrewkroh merged commit 5d1464c into elastic:7.x Dec 15, 2020
@zube zube bot removed the [zube]: Done label Mar 15, 2021
@andrewkroh andrewkroh deleted the backport_22966_7.x branch January 14, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants