Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23148 to 7.x: Fix vsphere.datastore.capacity.used.pct value by removing *100 #23167

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Cherry-pick #23148 to 7.x: Fix vsphere.datastore.capacity.used.pct value by removing *100 #23167

merged 2 commits into from
Dec 17, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 16, 2020

Cherry-pick of PR #23148 to 7.x branch. Original message:

What does this PR do?

This PR is to change vsphere.datastore.capacity.used.pct from int64 to float64, make sure the value is between 0-1.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Dec 16, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 16, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 16, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user kaiyan-sheng

  • Start Time: 2020-12-17T14:48:46.637+0000

  • Duration: 52 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 2294
Skipped 508
Total 2802

Steps errors 3

Expand to view the steps failures

metricbeat-goIntegTest - Install Go/Mage/Python/Docker/Terraform 1.14.12
  • Took 0 min 6 sec . View more details on here
  • Description: .ci/scripts/install-tools.sh
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
  • Description: terraform apply -auto-approve
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
  • Description: terraform apply -auto-approve

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2294
Skipped 508
Total 2802

@kaiyan-sheng kaiyan-sheng merged commit b1a1faf into elastic:7.x Dec 17, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_23148_7.x branch December 17, 2020 17:07
@zube zube bot removed the [zube]: Done label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants