-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder headers for infoblox module #23273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reorders the syslog headers parsers for the infoblox/nios dataset so that the simpler header is picked up first. Otherwise it will fail to properly parse logs. Fixes elastic#23272
adriansr
added
bug
review
needs_backport
PR is waiting to be backported to other branches.
Team:Security-External Integrations
labels
Dec 23, 2020
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Dec 23, 2020
Collaborator
marc-gr
approved these changes
Dec 24, 2020
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Dec 28, 2020
* Reorder headers for infoblox module This reorders the syslog headers parsers for the infoblox/nios dataset so that the simpler header is picked up first. Otherwise it will fail to properly parse logs. Fixes elastic#23272 * Changelog entry (cherry picked from commit 27d0f08)
2 tasks
adriansr
added
v7.12.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Dec 28, 2020
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Dec 28, 2020
* Reorder headers for infoblox module This reorders the syslog headers parsers for the infoblox/nios dataset so that the simpler header is picked up first. Otherwise it will fail to properly parse logs. Fixes elastic#23272 * Changelog entry (cherry picked from commit 27d0f08)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reorders the syslog headers parsers for the infoblox/nios dataset so that the simpler header is picked up first.
Why is it important?
Otherwise it will fail to parse logs in the default configuration.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Fixes #23272