-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synthetics docker image #23274
Synthetics docker image #23274
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Test | Results |
---|---|
Failed | 0 |
Passed | 17516 |
Skipped | 1383 |
Total | 18899 |
Pinging @elastic/uptime (Team:Uptime) |
/test please |
RUN yum -y --setopt=tsflags=nodocs update \ | ||
{{- if (eq .BeatName "heartbeat") }} | ||
&& yum -y install epel-release \ | ||
&& yum -y install atk cups gtk gdk xrandr pango.x86_64 libXcomposite.x86_64 libXcursor.x86_64 libXdamage.x86_64 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why all these dependencies? I think some of them can be avoided (atk, cups, pango). I can check it if I know which program needs them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are required by chrome unfortunately, I agree it seems excessive, but I got them from an official list that I can't seem to find anymore. Testing their removal one by one is something that's worthwhile in the future, I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can reduce the library dependencies later (if it is possible), I do not think is a blocker.
/test |
/test please |
/test please |
Adjusts the heartbeat docker image to install deps for heartbeat synthetics. Fixes elastic#22837 (cherry picked from commit dbc61ed)
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Adjusts the heartbeat docker image to install deps for heartbeat synthetics. Fixes #22837
What does this PR do?
Why is it important?
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs