Initial nomad support #23324
Closed
Initial nomad support #23324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for the basic hint features
Add tests for the emition of events
Add tests for the emition of events
…autodiscovery-nomad
…llocations Add local constants to track the possible status of the allocations
On older nomad versions (0.8.4) the `NodeName` attribute of the allocation is empty. This means that sometimes we cannot assign a proper `host` to the event. As a workaround we use the `NodeID` to get the the name from the actual client node.
This is a workaround for Nomad v0.8 that doesn't provide the NodeName directly in the allocation object. We use the NodeID to fetch it from the API.
Remove debug statement
- WIP emit only one task metadata event. - Rename the matchers/indexers of the add_nomad_metadata processor to match the Nomad lingo.
- Rename `meta.meta` to `meta.tasks` and fix the tests. - Add the main import to the nomad provider in the cmd tool.
WIP patch for the unchanged allocations and avoids triggering new harvesters for those allocations that were previously discovered.
- Rename `uuid` field to `alloc_id`. - Use WatchOptions.RefreshInterval (SyncInterval on the config) for the sync interval of the watcher
After PR elastic#20281 was merged, the signature of the `autodiscover.ProviderBuilder` changed to accept an additional name (string) parameter.
After catching up with the latest changes in master these files changed and CI was complaining about the difference.
* Rename host to node for filtering, following nomad terminology. * Pass address, namespace, region and secret ids to clients.
botelastic
bot
added
needs_team
|
This pull request doesn't have a |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 17550 |
| Skipped | 1385 |
| Total | 18935 |
4 tasks
|
Changes cherry-picked in original PR, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues with #14954.
Differences over original PR:
ClientStatusfor the allocation status instead of the job status (Autodiscover provider for Nomad #14954 (comment))allocation.*andjob.*.hostsetting tonode, following nomad terminology, and make it optional, local node will be autodiscovered by default (Autodiscover provider for Nomad #14954 (comment)).clusterscope.add_nomad_metadatain all x-pack beats.Co-Authored-By: Jorge Luis Betancourt Gonzalez jorge-luis.betancourt@trivago.com