Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default config in windows.yml #23327

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Update default config in windows.yml #23327

merged 2 commits into from
Jan 11, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Dec 30, 2020

What does this PR do?

Update default config in windows.yml file

Why is it important?

Updates default config in windows.yml, previous config is invalid

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 30, 2020
@narph narph self-assigned this Dec 30, 2020
@narph narph added the Team:Platforms Label for the Integrations - Platforms team label Dec 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 30, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 30, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23327 updated

  • Start Time: 2020-12-30T10:28:24.085+0000

  • Duration: 53 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 2288
Skipped 507
Total 2795

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
  • Description: terraform apply -auto-approve
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 16 sec . View more details on here
  • Description: terraform apply -auto-approve

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2288
Skipped 507
Total 2795

@narph narph mentioned this pull request Dec 30, 2020
Closed
kaiyan-sheng
kaiyan-sheng approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narph narph added the needs_backport PR is waiting to be backported to other branches. label Jan 11, 2021
@narph narph merged commit 6e1426c into elastic:master Jan 11, 2021
@narph narph deleted the win-doc branch January 11, 2021 15:38
@narph narph mentioned this pull request Jan 13, 2021
Merged
6 tasks
@narph narph added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 13, 2021
narph added a commit to narph/beats that referenced this pull request Jan 13, 2021
@narph
Update default config in windows.yml (elastic#23327)
1113770 
* update config

* changelog

(cherry picked from commit 6e1426c)
@narph narph mentioned this pull request Jan 13, 2021
Merged
6 tasks
@narph narph added the v7.11.0 label Jan 13, 2021
narph added a commit to narph/beats that referenced this pull request Jan 13, 2021
@narph
Update default config in windows.yml (elastic#23327)
add7284 
* update config

* changelog

(cherry picked from commit 6e1426c)
narph added a commit that referenced this pull request Jan 14, 2021
@narph
Update default config in windows.yml (#23327) (#23485)
46a47d5 
* update config

* changelog

(cherry picked from commit 6e1426c)
narph added a commit that referenced this pull request Jan 14, 2021
@narph
Update default config in windows.yml (#23327) (#23486)
94a799a 
* update config

* changelog

(cherry picked from commit 6e1426c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
Team:Platforms Label for the Integrations - Platforms team v7.11.0 v7.12.0 [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metricbeat Windows Module invalid windows.yml in modules.d
3 participants
@narph @elasticmachine @kaiyan-sheng