[Filebeat][httpjson] Adding possibility to use first_event in cursor context #23437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
|
As discussed with @marc-gr , the new functionality still requires tests, as there is also no tests for |
marc-gr
reviewed
Jan 12, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
force-pushed
the
filebeat_httpjson_first_event
branch
from
2fd5cf1
to
111e550
Compare
…ts into filebeat_httpjson_first_event
marc-gr
added
the
needs_backport
6 tasks
marc-gr
added
v7.12.0
and removed
needs_backport
marc-gr
pushed a commit
to marc-gr/beats
that referenced
this pull request
Jan 25, 2021
…context (elastic#23437) * adding possibility to use first_event context in httpjson * fixing typo * Add transform context state test * updating changelog Co-authored-by: Marc Guasch <marc.guasch@elastic.co> (cherry picked from commit d4e85e0)
marc-gr
added a commit
that referenced
this pull request
Jan 25, 2021
…context (#23437) (#23491) * adding possibility to use first_event context in httpjson * fixing typo * Add transform context state test * updating changelog Co-authored-by: Marc Guasch <marc.guasch@elastic.co> (cherry picked from commit d4e85e0) Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extends the context to also support first_event, similar to last_event and last_response, this is to be able to support API's that returns the newest event first instead of last.
Why is it important?
Multiple modules are blocked while missing this functionality.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Closes #23358