[Filebeat] add encode form and decode ndjson to httpjson input #23521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
- support "application/x-www-form-urlencoded", url parameters are encoded and sent in the body - support "application/x-ndjson", json objects are decoded and returned in an array at root level
leehinman
force-pushed
the
post_x_www_form_urlencoded
branch
from
b63c0ee
to
0a4a44a
Compare
leehinman
added
enhancement
Filebeat
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
reviewed
Jan 15, 2021
| } | ||
|
|
||
| func encodeAsJSON(trReq transformable) ([]byte, error) { | ||
| if len(trReq.body()) == 0 { |
marc-gr
reviewed
Jan 15, 2021
Comment on lines
113
to
122
| for { | ||
| var o interface{} | ||
| err := dec.Decode(&o) | ||
| if err == io.EOF { | ||
| break | ||
| } else if err != nil { | ||
| return err | ||
| } | ||
| results = append(results, o) | ||
| } |
There was a problem hiding this comment.
Suggested change
| for { | |
| var o interface{} | |
| err := dec.Decode(&o) | |
| if err == io.EOF { | |
| break | |
| } else if err != nil { | |
| return err | |
| } | |
| results = append(results, o) | |
| } | |
| for dec.More() { | |
| var o interface{} | |
| if err := dec.Decode(&o); err != nil { | |
| return err | |
| } | |
| results = append(results, o) | |
| } |
marc-gr
approved these changes
Jan 15, 2021
2 tasks
Merged
4 tasks
leehinman
added
v7.12.0
and removed
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
request.encode_asoption. url parameters are encoded and sent inthe body
response.decode_asoption. json objects are decoded and returnedin an array at root level
Why is it important?
Some API endpoints require posting data as
application/x-www-form-urlencodedSome API endpoints only return
application/x-ndjsonnot jsonChecklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.