Fix permissions for synthetics docker image #23576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The permissions were incorrect, and mostly set for the wrong UID. This fixes that, performing most tasks as a regular user.
botelastic
bot
added
the
needs_team
andrewvc
added
bug
Heartbeat
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
removed
the
needs_team
|
/packaging |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
vigneshshanmugam
approved these changes
Jan 21, 2021
| # Setup node | ||
| RUN cd /usr/share/heartbeat/.node \ | ||
| && mkdir -p node \ | ||
| && curl https://nodejs.org/dist/v12.18.4/node-v12.18.4-linux-x64.tar.xz | tar -xJ --strip 1 -C node \ |
There was a problem hiding this comment.
use NODE_VERSION var here as well?
There was a problem hiding this comment.
Let's fix this in a follow-up, I think we want to bump this version before beta anyway.
| && mkdir -p node \ | ||
| && curl https://nodejs.org/dist/v12.18.4/node-v12.18.4-linux-x64.tar.xz | tar -xJ --strip 1 -C node \ | ||
| && chmod ug+rwX -R $NODE_PATH \ | ||
| && npm i -g -f @elastic/synthetics && chmod ug+rwX -R $NODE_PATH |
There was a problem hiding this comment.
do we still need -f for this as this happens only when we build the heartbeat image?
There was a problem hiding this comment.
Given that this is tested and works, I'd rather postpone this change to a subsequent PR and unbreak the current build
jsoriano
approved these changes
Jan 21, 2021
6 tasks
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Jan 21, 2021
The permissions were incorrect, and mostly set for the wrong UID. This fixes that, performing most tasks as a regular user. (cherry picked from commit f527935)
andrewvc
added a commit
that referenced
this pull request
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permissions were incorrect, and mostly set for the wrong UID, running synthetic monitors would fail completely. This fixes that, performing most tasks as a regular user.
Fixes: #23577
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run
env PLATFORMS="+all linux/amd64" mage packageinx-pack/heartbeat. Then, using the synthetics repo, run./run.sh docker.elastic.co/beats/heartbeat:8.0.0from theexamples/dockerdir.