Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Winlogbeat] Remove 4912 evtx from testing #23669

Merged
merged 1 commit into from
Jan 25, 2021
Merged

[Winlogbeat] Remove 4912 evtx from testing #23669

merged 1 commit into from
Jan 25, 2021

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Remove 4912 evtx from Winlogbeat testing

Why is it important?

  • causing failures on Win 7,8, 2008R2 & 2012R2

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@leehinman
Remove 4912 evtx from testing
14a28bb 
- causing failures on Win 7,8, 2008R2 & 2012R2
@leehinman leehinman requested a review from a team as a code owner January 25, 2021 20:46
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2021
@leehinman leehinman added bug needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations Winlogbeat labels Jan 25, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh
Copy link
Member

I assume that 4912 didn't exist in those earlier Windows versions which is why there are problems with testing.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 25, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: andrewkroh commented: run tests

    • Start Time: 2021-01-25T21:12:47.696+0000

  • Duration: 33 min 28 sec

  • Commit: 14a28bb

Test stats 🧪

Test Results
Failed 0
Passed 1374
Skipped 14
Total 1388

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1374
Skipped 14
Total 1388

@andrewkroh andrewkroh added windows-10 Enable builds in the CI for windows-10 windows-2008 Enable builds in the CI for windows-2008 windows-7 Enable builds in the CI for windows-7 windows-7-32 Enable builds in the CI for windows-7 32 bits windows-8 Enable builds in the CI for windows-8 labels Jan 25, 2021
@andrewkroh
Copy link
Member

run tests

@leehinman leehinman merged commit d4e193d into elastic:master Jan 25, 2021
v1v added a commit to v1v/beats that referenced this pull request Jan 26, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/linting-x…
b9ddb3b 
…pack-when-oss-changes

* upstream/master:
  [DOCS] Add setup content to Kubernetes and Cloud Foundry docs (elastic#23580)
  [CI] Mandatory windows support for all the versions (elastic#23615)
  Add check when retrieving the worker process id using performance counters  (elastic#23647)
  Remove 4912 evtx from testing (elastic#23669)
  Add missing SSL settings (elastic#23632)
  Update X-Pack Packetbeat config (elastic#23666)
  Use hostname check from verify.go to handle patterns in TLS certs (elastic#23661)
  Fix: Dissect Cisco ASA 302013 message usernames (elastic#21196)
  Add FAQ entry for MADV settings in older versions (elastic#23429)
  Sync fixes from Integration Package Testing (elastic#23424)
  [Filebeat] Add Cisco ASA message '302023' parsing (elastic#23092)
  [Elastic Log Driver] Change hosts config flag (elastic#23628)
  Audit and Authentication Policy Change Events (elastic#20684)
@leehinman leehinman mentioned this pull request Jan 26, 2021
Closed
6 tasks
leehinman added a commit to leehinman/beats that referenced this pull request Jan 27, 2021
@leehinman
Remove 4912 evtx from testing (elastic#23669)
78ef8f1 
- causing failures on Win 7,8, 2008R2 & 2012R2

(cherry picked from commit d4e193d)
andrewkroh pushed a commit that referenced this pull request Feb 1, 2021
@leehinman @janniten
Cherry-pick #20684 to 7.x: Audit and Authentication Policy Change Eve…
7fc2b2a 
…nts (#23659)

* Audit and Authentication Policy Change Events (#20684)

* [Winlogbeat] Audit and Authentication Policy Change Events

Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co>
(cherry picked from commit dd7a1b3)

* Remove 4912 evtx from testing (#23669)

- causing failures on Win 7,8, 2008R2 & 2012R2

(cherry picked from commit d4e193d)

* Add Winlogbeat Security Module Doc (#23674)

* Add Winlogbeat Security Module Doc

* Update source file used to generate security module docs

(cherry picked from commit ee485bd)

Co-authored-by: Anabella Cristaldi <33020901+janniten@users.noreply.github.com>
@leehinman leehinman deleted the remove_4912_evtx branch May 14, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
bug needs_backport PR is waiting to be backported to other branches. windows-7-32 Enable builds in the CI for windows-7 32 bits windows-7 Enable builds in the CI for windows-7 windows-8 Enable builds in the CI for windows-8 windows-10 Enable builds in the CI for windows-10 windows-2008 Enable builds in the CI for windows-2008 Winlogbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leehinman @elasticmachine @andrewkroh