-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Populate source/destination.mac for Suricata #23721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
enhancement
review
Filebeat
Filebeat
needs_backport
PR is waiting to be backported to other branches.
Team:Security-External Integrations
labels
Jan 27, 2021
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jan 27, 2021
andrewkroh
force-pushed
the
feature/fb/suricata-mac
branch
from
January 27, 2021 19:41
3d272e1
to
b966e24
Compare
When 'ethernet' is enabled in Suricata with will log the mac addresses. ECS has fields for the MAC addresses so this renames the two Suricata fields to follow the ECS conventions. Closes elastic#23706
andrewkroh
force-pushed
the
feature/fb/suricata-mac
branch
from
January 27, 2021 19:43
b966e24
to
2578ff1
Compare
leehinman
approved these changes
Jan 27, 2021
run tests |
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
run tests |
1 similar comment
run tests |
4 tasks
andrewkroh
added
v7.12.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Feb 3, 2021
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Feb 12, 2021
When 'ethernet' is enabled in Suricata with will log the mac addresses. ECS has fields for the MAC addresses so this renames the two Suricata fields to follow the ECS conventions. Closes elastic#23706 (cherry picked from commit 10fdd24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When 'ethernet' is enabled in Suricata with will log the mac addresses.
ECS has fields for the MAC addresses so this renames the two Suricata
fields to follow the ECS conventions.
Closes #23706
Why is it important?
This make the fields consistent between data sources.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areasCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues