Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Populate source/destination.mac for Suricata #23721

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

andrewkroh
Copy link
Member

What does this PR do?

When 'ethernet' is enabled in Suricata with will log the mac addresses.
ECS has fields for the MAC addresses so this renames the two Suricata
fields to follow the ECS conventions.

Closes #23706

Why is it important?

This make the fields consistent between data sources.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • ~[ ] I have made corresponding change to the default configuration files`
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 27, 2021
When 'ethernet' is enabled in Suricata with will log the mac addresses.
ECS has fields for the MAC addresses so this renames the two Suricata
fields to follow the ECS conventions.

Closes elastic#23706
@andrewkroh
Copy link
Member Author

run tests

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 1, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: andrewkroh commented: run tests

    • Start Time: 2021-02-03T06:25:03.499+0000
  • Duration: 48 min 17 sec

  • Commit: 539e4ca

Test stats 🧪

Test Results
Failed 0
Passed 13000
Skipped 2033
Total 15033

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13000
Skipped 2033
Total 15033

@andrewkroh
Copy link
Member Author

run tests

1 similar comment
@andrewkroh
Copy link
Member Author

run tests

@andrewkroh andrewkroh merged commit 10fdd24 into elastic:master Feb 3, 2021
@andrewkroh andrewkroh added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 3, 2021
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Feb 12, 2021
When 'ethernet' is enabled in Suricata with will log the mac addresses.
ECS has fields for the MAC addresses so this renames the two Suricata
fields to follow the ECS conventions.

Closes elastic#23706

(cherry picked from commit 10fdd24)
andrewkroh added a commit that referenced this pull request Feb 16, 2021
… for Suricata (#23834)

When 'ethernet' is enabled in Suricata with will log the mac addresses.
ECS has fields for the MAC addresses so this renames the two Suricata
fields to follow the ECS conventions.

Closes #23706

(cherry picked from commit 10fdd24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MAC address mapping to ECS in Filebeat Suricata module
3 participants