-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
o365: Fix processing of ModifiedProperties field #23777
Merged
adriansr
merged 2 commits into
elastic:master
from
adriansr:fix-o365-modified-properties
Feb 1, 2021
Merged
o365: Fix processing of ModifiedProperties field #23777
adriansr
merged 2 commits into
elastic:master
from
adriansr:fix-o365-modified-properties
Feb 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was causing entries for the ModifiedProperties field to be dropped.
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Feb 1, 2021
adriansr
added
bug
needs_backport
PR is waiting to be backported to other branches.
review
labels
Feb 1, 2021
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
andrewkroh
approved these changes
Feb 1, 2021
leehinman
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Feb 1, 2021
A bug was causing entries for the ModifiedProperties field to be dropped. (cherry picked from commit 1f8a2e6)
6 tasks
adriansr
added
v7.12.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Feb 1, 2021
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Feb 1, 2021
A bug was causing entries for the ModifiedProperties field to be dropped. (cherry picked from commit 1f8a2e6)
6 tasks
adriansr
added a commit
that referenced
this pull request
Feb 1, 2021
adriansr
added a commit
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug in the handling of
ModifiedProperties
field from O365 Management API events.Why is it important?
This bug was causing the field to not be included in the resulting document.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.