Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container image and container name ECS fields for state_container #23802

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Feb 2, 2021

What does this PR do?

Most probably this was not caught at #13884.
With this PR kubernetes.container.name is being copied to container.name and kubernetes.container.name is being copied to container.image.name based on container ECS.

kubernetes.container.* fields will not be removed until 8.0 elastic stack release.

Related to #23585

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added review containers Related to containers use case ecs v7.12.0 kubernetes Enable builds in the CI for kubernetes labels Feb 2, 2021
@ChrsMark ChrsMark self-assigned this Feb 2, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 2, 2021
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23802 updated

    • Start Time: 2021-02-02T12:40:08.661+0000
  • Duration: 64 min 4 sec

  • Commit: ecb0849

Test stats 🧪

Test Results
Failed 0
Passed 8379
Skipped 2098
Total 10477

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8379
Skipped 2098
Total 10477

@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Feb 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 2, 2021
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but linting issues are related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case ecs kubernetes Enable builds in the CI for kubernetes review Team:Integrations Label for the Integrations team v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants