Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23944 to 7.x: [Filebeat] Convert logstash logEvent.action objects to strings #24063

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Feb 16, 2021

Cherry-pick of PR #23944 to 7.x branch. Original message:

What does this PR do?

To prevent index failures resulting from indexing a mix of strings and nested objects as
logstash.log.log_event.action, this converts any objects to a stringified version of the object
using painless toString().

Fixes #20709

Why is it important?

See #20709 for details on the failure. This fixes index failures when ingesting Logstash logs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

…ic#23944)

To prevent index failures resulting from indexing a mix of strings and nested objects as
logstash.log.log_event.action, this converts any objects to a stringified version of the object
using painless toString().

Fixes elastic#20709

(cherry picked from commit 0d4109d)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24063 opened

  • Start Time: 2021-02-16T14:39:45.967+0000

  • Duration: 48 min 29 sec

  • Commit: 58f9eb0

Test stats 🧪

Test Results
Failed 0
Passed 13006
Skipped 2061
Total 15067

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13006
Skipped 2061
Total 15067

@andrewkroh andrewkroh merged commit 361eb92 into elastic:7.x Feb 16, 2021
@zube zube bot removed the [zube]: Done label May 18, 2021
@andrewkroh andrewkroh deleted the backport_23944_7.x branch January 14, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants