Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23887 to 7.x: Check fields are documented for aws metricsets #24068

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Cherry-pick #23887 to 7.x: Check fields are documented for aws metricsets #24068

merged 1 commit into from
Feb 16, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Feb 16, 2021

Cherry-pick of PR #23887 to 7.x branch. Original message:

What does this PR do?

This PR is to unskip flaky test in s3_request metricset and add check on fields to see if they are documented: #21826

This PR also add TestMetricsetFieldsDocumented for fields from rds, s3_daily_storage, s3_request, sqs and cloudwatch metricsets: #17337

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 16, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Feb 16, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24068 opened

  • Start Time: 2021-02-16T17:54:04.577+0000

  • Duration: 36 min 50 sec

  • Commit: b301436

Test stats 🧪

Test Results
Failed 0
Passed 2455
Skipped 216
Total 2671

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2455
Skipped 216
Total 2671

@kaiyan-sheng kaiyan-sheng merged commit 2810f72 into elastic:7.x Feb 16, 2021
@kaiyan-sheng kaiyan-sheng deleted the backport_23887_7.x branch February 16, 2021 19:35
@zube zube bot removed the [zube]: Done label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants