Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Google Cloud: Do not try to setup region filter on Cloudfunctions metrics #24218

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Feb 24, 2021

What does this PR do?

This PR solves a bug that appears when setting a region parameter in gcp.yml only when using CloudFunctions.

Some Google Cloud services fail when you request metrics filtering by region. Beats has faced the same situation when requesting PubSub or LoadBalancing metrics from Stackdriver (Stackdriver is the service requested in metrics metricset).

Requests to those services must be done explicitly without filtering by region. Unfortunately, this isn't very well documented in GCP docs (or it's well hidden 😄 )

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@sayden sayden added bug Metricbeat Metricbeat Team:Services (Deprecated) Label for the former Integrations-Services team labels Feb 24, 2021
@sayden sayden self-assigned this Feb 24, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 24, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 24, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24218 updated

  • Start Time: 2021-02-24T21:33:48.874+0000

  • Duration: 37 min 56 sec

  • Commit: ba0103b

Test stats 🧪

Test Results
Failed 0
Passed 2455
Skipped 216
Total 2671

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2455
Skipped 216
Total 2671

@v1v
Copy link
Member

v1v commented Feb 24, 2021

/test

@sayden sayden merged commit a6a3d6d into elastic:master Feb 25, 2021
@sayden sayden added the v7.13.0 label Feb 25, 2021
sayden added a commit to sayden/beats that referenced this pull request Feb 25, 2021
sayden added a commit that referenced this pull request Mar 1, 2021
@sayden sayden deleted the bugfix/xp/mb/googlecloud/do_not_modify_cloud_functions_filters branch August 25, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Metricbeat Metricbeat Team:Services (Deprecated) Label for the former Integrations-Services team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants