Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24241 to 7.12: Fix state_node conditions ' types #24244

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Feb 25, 2021

Cherry-pick of PR #24241 to 7.12 branch. Original message:

What does this PR do?

This PR fixes the type of kubernetes.node.status.* of state_node metricset from boolean to keyword since the value can be one of "true, false or unknown".

Fields were added at #23905

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 25, 2021
@botelastic
Copy link

botelastic bot commented Feb 25, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 25, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: ChrsMark commented: /test

  • Start Time: 2021-02-25T15:11:15.127+0000

  • Duration: 93 min 48 sec

  • Commit: 83513d7

Test stats 🧪

Test Results
Failed 0
Passed 8658
Skipped 2122
Total 10780

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8658
Skipped 2122
Total 10780

@ChrsMark
Copy link
Member Author

/test

1 similar comment
@ChrsMark
Copy link
Member Author

/test

@ChrsMark ChrsMark merged commit b0de20e into elastic:7.12 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants