Cherry-pick to 7.12: [Heartbeat] Remove warning around messages sent outside journeys (#24366) #24369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#24366) This removes the annoying and useless warning sent when events are received outside a journey context. This was meant to be a useful invariant catching weird bugs on the synthetics side. In practice, it mostly just doubles the output when errors are received due to a misconfigured environment. This patch removes this behavior. I don't think there's a strong case to add it back in, it was always a nice-to-have for a hypothetical situation.
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
jsoriano
added
Team:Elastic-Agent
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/uptime (Team:Uptime) |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stic#24366) (elastic#24369) This removes the annoying and useless warning sent when events are received outside a journey context. This was meant to be a useful invariant catching weird bugs on the synthetics side. In practice, it mostly just doubles the output when errors are received due to a misconfigured environment. This patch removes this behavior. I don't think there's a strong case to add it back in, it was always a nice-to-have for a hypothetical situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.12: