Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Improve Endpoint installation logging #24429

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Mar 8, 2021

What does this PR do?

Improves the logging of the installation process for Endpoint Security. Now when Endpoint Security fails to install or uninstall the output of the command will be provided in the error message.

Why is it important?

So when Endpoint Security fails to install it is easier to debug what occurred.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added needs_backport PR is waiting to be backported to other branches. Team:Elastic-Agent Label for the Agent team labels Mar 8, 2021
@blakerouse blakerouse self-assigned this Mar 8, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 8, 2021
@blakerouse blakerouse marked this pull request as ready for review March 8, 2021 19:17
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@ph
Copy link
Contributor

ph commented Mar 8, 2021

fyi @ferullo

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24429 event

  • Start Time: 2021-03-08T19:18:21.580+0000

  • Duration: 49 min 37 sec

  • Commit: e6c1e88

Test stats 🧪

Test Results
Failed 0
Passed 6580
Skipped 16
Total 6596

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6580
Skipped 16
Total 6596

@@ -11,12 +11,16 @@ check_install:
path: "endpoint-security"
args:
- "verify"
- "--log"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command updates in this file look good. 👍

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@blakerouse blakerouse merged commit 8efc24c into elastic:master Mar 9, 2021
@blakerouse blakerouse added v7.13.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 9, 2021
@blakerouse blakerouse deleted the improve-agent-exec-logging branch March 9, 2021 13:32
blakerouse added a commit to blakerouse/beats that referenced this pull request Mar 9, 2021
* Improve logging of exec_file_step.

* Add --log stderr to endpoint.

* Add changelog.

(cherry picked from commit 8efc24c)
blakerouse added a commit to blakerouse/beats that referenced this pull request Mar 9, 2021
* Improve logging of exec_file_step.

* Add --log stderr to endpoint.

* Add changelog.

(cherry picked from commit 8efc24c)
blakerouse added a commit that referenced this pull request Mar 9, 2021
* Improve logging of exec_file_step.

* Add --log stderr to endpoint.

* Add changelog.

(cherry picked from commit 8efc24c)
blakerouse added a commit that referenced this pull request Mar 9, 2021
* Improve logging of exec_file_step.

* Add --log stderr to endpoint.

* Add changelog.

(cherry picked from commit 8efc24c)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…elastic#24439)

* Improve logging of exec_file_step.

* Add --log stderr to endpoint.

* Add changelog.

(cherry picked from commit 24799c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more output when Agent can't install Endpoint
5 participants