Disable cleanup_timeout by default in docker and kubernetes autodiscover #24681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
review
needs_backport
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
jsoriano
force-pushed
the
disable-cleanup-timeout
branch
from
4ae2235
to
f4ffe6f
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
/test |
|
/package |
|
/test |
|
/test |
1 similar comment
|
/test |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 24, 2021
…ver (elastic#24681) It is kept to 60 seconds in Filebeat, to give a time to collect logs. Keeping configurations running for some time after containers have stopped is needed in some cases to complete the collection of logs. But in the rest of cases it is not usually needed, and leads to errors when querying endpoints known to be down. It can also lead to query IPs that are being reused in newer containers, what can be misleading if the newer pod answers because these events will still have the metadata of the old container. (cherry picked from commit 439b808)
6 tasks
jsoriano
removed
the
needs_backport
jsoriano
added a commit
that referenced
this pull request
Mar 24, 2021
…ver (#24681) (#24730) It is kept to 60 seconds in Filebeat, to give a time to collect logs. Keeping configurations running for some time after containers have stopped is needed in some cases to complete the collection of logs. But in the rest of cases it is not usually needed, and leads to errors when querying endpoints known to be down. It can also lead to query IPs that are being reused in newer containers, what can be misleading if the newer pod answers because these events will still have the metadata of the old container. (cherry picked from commit 439b808)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disable
cleanup_timeoutby default in docker and kubernetes autodiscover for all beats except Filebeat.It is kept to 60 seconds in Filebeat, to give a time to collect logs.
Why is it important?
Keeping configurations running for some time after containers have stopped is needed in some cases to complete the collection of logs. But in the rest of cases it is not usually needed, and leads to errors when querying endpoints known to be down.
It can also lead to query IPs that are being reused in newer containers, what can be misleading if the newer pod answers because these events will still have the metadata of the old container.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues