[Elastic Agent] Adjust to Fleet Server connection information from Kibana in configuration #24713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
This is now ready to land. The change has already landed in Kibana and Endpoint Security. |
| } | ||
| } | ||
|
|
||
| return nil | ||
| return newAST.root.(*Dict), nil |
There was a problem hiding this comment.
I added a guard to prevent possible panic
| } | ||
| values[idx] = newAST.root | ||
| } | ||
| } | ||
| return nil | ||
| return l, nil |
There was a problem hiding this comment.
returning same what we passed in?
There was a problem hiding this comment.
This is so mapList and mapDict have the same behavior of returning possible a new node. In the case of mapList it will not return a new node, but in mapDict it does.
blakerouse
added a commit
that referenced
this pull request
Apr 8, 2021
…bana in configuration (#24713) (#24992) * Adjust fleet.kibana.* to just fleet.* * Switch from fleet.kibana.* to fleet.* for connection. * Add changelog entry. * Add check to ensure no possible panic in mapDict. (cherry picked from commit 974f255) Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adjusts the Elastic Agent to look for connection information to Fleet Server at
fleet.hostsinstead offleet.kibana.hosts.NOTE: This is a breaking change and needs to land at the same time as elastic/kibana#94364
NOTE: This also requires that Endpoint Security adjust how it reads the Fleet configuration from the configuration that Elastic Agent sends it.
Why is it important?
With the transition to Fleet Server from Kibana, Elastic Agent no longer talks directly to Kibana and needs connection information to Fleet Server instead of Kibana.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.