Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Merge synthetic root fields into events #24770

Merged
merged 5 commits into from
Mar 30, 2021

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Mar 25, 2021

Fixes #24768

This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in root_fields get merged into the event root.

This also improves the testing in this area of the code, which was somewhat lean (and really was only tested in larger functional tests run elsewhere)

Why is it important?

Without this any field change must be made in two places (synthetics and here), this simplifies our arch.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Check that things still work end-to-end without any obvious breakage

Fixes elastic#24768

This allows synthetics to drive more field names without requiring
heartbeat updates. Any fields in `root_fields` get merged into the event
root.
@andrewvc andrewvc added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.13.0 labels Mar 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 25, 2021
@andrewvc andrewvc self-assigned this Mar 25, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 25, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24770 updated

  • Start Time: 2021-03-26T16:31:03.334+0000

  • Duration: 72 min 26 sec

  • Commit: cba9081

Test stats 🧪

Test Results
Failed 0
Passed 53
Skipped 0
Total 53

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 53
Skipped 0
Total 53

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrewvc andrewvc merged commit 2b00b83 into elastic:master Mar 30, 2021
@andrewvc andrewvc deleted the root_fields branch March 30, 2021 18:48
andrewvc added a commit to andrewvc/beats that referenced this pull request Mar 30, 2021
Fixes elastic#24768

This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in root_fields get merged into the event root.

This also improves the testing in this area of the code, which was somewhat lean (and really was only tested in larger functional tests run elsewhere)
andrewvc added a commit that referenced this pull request Mar 30, 2021
Fixes #24768

This allows synthetics to drive more field names without requiring heartbeat updates. Any fields in root_fields get merged into the event root.

This also improves the testing in this area of the code, which was somewhat lean (and really was only tested in larger functional tests run elsewhere)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Heartbeat] Root fields for synthetics
3 participants