Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud.service.name to add_cloud_metadata #24993

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

andrewstucki
Copy link

What does this PR do?

This adds the new ECS 1.9 field cloud.service.name to add_cloud_metadata.

I tried to use the names of each service we're retrieving metadata for as it exists in the majority of the literature. In some cases this means this uses shorthand names (i.e. EC2) and, when shorthand isn't commonly in the cloud provider's docs (i.e. AWS), the full name is used (i.e. Virtual Machines).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 8, 2021
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For quick reference this PR uses these values:

Provider cloud.service.name
Alibaba ECS
AWS EC2
Azure Virtual Machines
Digital Ocean Droplets
Google GCE
OpenStack Nova
Tencent CVM

@andrewkroh andrewkroh added the backport-v7.13.0 Automated backport with mergify label Apr 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 8, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Andrew Stucki

  • Start Time: 2021-04-09T13:20:22.966+0000

  • Duration: 66 min 23 sec

  • Commit: 72ea6d6

Test stats 🧪

Test Results
Failed 0
Passed 46806
Skipped 5132
Total 51938

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46806
Skipped 5132
Total 51938

@andrewstucki andrewstucki merged commit 5bde9d0 into elastic:master Apr 9, 2021
@andrewstucki andrewstucki deleted the add-service-name branch April 9, 2021 14:27
mergify bot pushed a commit that referenced this pull request Apr 9, 2021
* Add cloud.service.name to add_cloud_metadata

* update changelog

(cherry picked from commit 5bde9d0)
andrewstucki pushed a commit that referenced this pull request Apr 9, 2021
* Add cloud.service.name to add_cloud_metadata

* update changelog

(cherry picked from commit 5bde9d0)

Co-authored-by: Andrew Stucki <andrew.stucki@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request Apr 14, 2021
* upstream/master: (308 commits)
  [winlogbeat] Add support for sysmon v13 events 24 and 25 (elastic#24945)
  mergify: add backport label (elastic#25050)
  Add pod.ip in k8s metadata (elastic#25037)
  [elastic-agent] Use fleet.url for container cmd (elastic#25026)
  disable TestXPackEnabled flaky test in logstash metricbeat module (elastic#25034)
  Leverege leader election in agent  k8s manifests (elastic#25016)
  libbeat/publisher/pipeline: expand monitoring (elastic#24700)
  libbeat: fix decode_json_fields config validation (elastic#24862)
  Remove make docs-preview instructions (elastic#25001)
  [Filebeat] Fix IPtables pipeline (elastic#24928)
  [DOCS] cd into correct directory before invoking mage. (elastic#17679)
  Add -buildmode=pie for supported platform (elastic#24964)
  Add agent's direcotry in k8s manifest generator (elastic#24987)
  [mergify] assign the original author (elastic#25007)
  Fix AWS module flaky tests (elastic#24852)
  [filebeat] Use fail_on_template_error on google_workspace and okta pagination (elastic#24967)
  Updated config to match defaults (elastic#25004)
  [Filebeat] Fix hardcoded amazonaws.com endpoint (elastic#24861)
  Add cloud.service.name to add_cloud_metadata (elastic#24993)
  [Ingest Manager] Expose processes and their metrics (elastic#24788)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants