Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update decode_json_fields.asciidoc #25056

Merged
merged 7 commits into from
Apr 21, 2021
Merged

Update decode_json_fields.asciidoc #25056

merged 7 commits into from
Apr 21, 2021

Conversation

leahleahy
Copy link
Contributor

No description provided.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 13, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 13, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: bmorelli25 commented: Jenkins, run the tests please

  • Start Time: 2021-04-20T19:39:50.714+0000

  • Duration: 21 min 47 sec

  • Commit: b7b920a

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@bmorelli25 bmorelli25 requested a review from a team April 13, 2021 22:34
@bmorelli25 bmorelli25 added Team:Docs Label for the Observability docs team v7.12.0 labels Apr 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 13, 2021
@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member

Jenkins, run the tests please

dedemorton
dedemorton previously requested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please see my comments.

libbeat/processors/actions/docs/decode_json_fields.asciidoc Outdated Show resolved Hide resolved
libbeat/processors/actions/docs/decode_json_fields.asciidoc Outdated Show resolved Hide resolved
libbeat/processors/actions/docs/decode_json_fields.asciidoc Outdated Show resolved Hide resolved
libbeat/processors/actions/docs/decode_json_fields.asciidoc Outdated
default value is false.
`document_id`:: (Optional) JSON key to use as the document id. If configured,
the field will be removed from the original json document and stored in
`add_error_key`:: (Optional) If it set to `true`, in case of error while decoding JSON keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This edit needs more work. The sentence is hard to parse and has grammatical issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworked this, let me know what you think!

@bmorelli25
Copy link
Member

Jenkins, run the tests please

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25 bmorelli25 dismissed dedemorton’s stale review April 20, 2021 19:59

Another member of obs-docs has approved

@bmorelli25 bmorelli25 merged commit cd4d742 into elastic:master Apr 21, 2021
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Apr 21, 2021
@leahleahy @dedemorton @bmorelli25
Update decode_json_fields.asciidoc (elastic#25056)
613e993 
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
@bmorelli25 bmorelli25 mentioned this pull request Apr 21, 2021
Merged
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Apr 21, 2021
@leahleahy @dedemorton @bmorelli25
Update decode_json_fields.asciidoc (elastic#25056)
8bdf66d 
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
@bmorelli25 bmorelli25 mentioned this pull request Apr 21, 2021
Merged
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Apr 21, 2021
@leahleahy @dedemorton @bmorelli25
Update decode_json_fields.asciidoc (elastic#25056)
4906c39 
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
@bmorelli25 bmorelli25 mentioned this pull request Apr 21, 2021
Merged
v1v added a commit to v1v/beats that referenced this pull request Apr 22, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/customise…
d041fa1 
…-github-pr-comment-template

* upstream/master:
  Add support for parsers in filestream input (elastic#24763)
  Skip flaky test TestFilestreamTruncate (elastic#25218)
  backport: Add 7.13 branch (elastic#25189)
  Update decode_json_fields.asciidoc (elastic#25056)
  [Elastic Agent] Fix status and inspect command to work inside running container (elastic#25204)
v1v added a commit to v1v/beats that referenced this pull request Apr 22, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/pin-testi…
82ffbd4 
…ng-versions-stack

* upstream/master: (28 commits)
  Add support for parsers in filestream input (elastic#24763)
  Skip flaky test TestFilestreamTruncate (elastic#25218)
  backport: Add 7.13 branch (elastic#25189)
  Update decode_json_fields.asciidoc (elastic#25056)
  [Elastic Agent] Fix status and inspect command to work inside running container (elastic#25204)
  Check native environment before starting (elastic#25186)
  Change event.code and winlog.event_id type (elastic#25176)
  [Ingest Manager] Proxy processes/elastic-agent to stats (elastic#25193)
  Update mergify backporting to 7.x and 7.13 (elastic#25196)
  [Heartbeat]: ensure synthetics version co* [Heartbeat]: ensure synthetics version compatability for suites  * address review and fix notice  * fix lowercase struct  * fix version conflict and rebase  * update go.* stuff to master  * fix notice.txt  * move validate inside sourcempatability for suites (elastic#24777)
  [Filebeat] Ensure Kibana audit `event.category` and `event.type` are still processed as strings. (elastic#25101)
  Update replace.asciidoc (elastic#25055)
  Fix nil panic when overwriting metadata (elastic#24741)
  [Filebeat] Add Malware Bazaar to Threat Intel Module (elastic#24570)
  Fix k8s svc selectors mapping (elastic#25169)
  [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163)
  [Metricbeat] Remove elasticsearc.index.created from the SM code (elastic#25113)
  [Ingest Manager] Keep http and logging config during enroll (elastic#25132)
  Refactor kubernetes autodiscover to avoid skipping short-living pods (elastic#24742)
  [libbeat] New decode xml wineventlog processor (elastic#25115)
  ...
bmorelli25 added a commit that referenced this pull request Apr 23, 2021
@bmorelli25 @leahleahy @dedemorton
Update decode_json_fields.asciidoc (#25056) (#25212)
32210bd 
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

Co-authored-by: leahleahy <82116004+leahleahy@users.noreply.github.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25 added a commit that referenced this pull request Apr 23, 2021
@bmorelli25 @leahleahy @dedemorton
Update decode_json_fields.asciidoc (#25056) (#25213)
decff49 
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

Co-authored-by: leahleahy <82116004+leahleahy@users.noreply.github.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25 added a commit that referenced this pull request Apr 23, 2021
@bmorelli25 @leahleahy @dedemorton
Update decode_json_fields.asciidoc (#25056) (#25214)
4fc9a41 
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

Co-authored-by: leahleahy <82116004+leahleahy@users.noreply.github.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@bmorelli25 @leahleahy @dedemorton
Update decode_json_fields.asciidoc (elastic#25056) (elastic#25214)
8ecd040 
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

Co-authored-by: leahleahy <82116004+leahleahy@users.noreply.github.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@dedemorton dedemorton Awaiting requested review from dedemorton

Assignees

@leahleahy leahleahy

Labels
Team:Docs Label for the Observability docs team v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leahleahy @elasticmachine @bmorelli25 @dedemorton