New option in filestream: include_files && check after symlink is resolved
#25080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
Failing tests are unrelated. |
kvch
force-pushed
the
feature-filebeat-filestream-include-files
branch
from
8637358
to
25673ce
Compare
urso
reviewed
Apr 21, 2021
urso
reviewed
Apr 21, 2021
urso
approved these changes
Apr 22, 2021
4 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Apr 22, 2021
… resolved (elastic#25080) ## What does this PR do? This PR adds support for a new feature in `filestream` input named `include_files`. This option is the counterpart of `exclude_files`. It expects a list of regexes and it only includes files that match the regexes. The PR also adds one more check after symlinks are resolved, the original file is tested again with the regexes in `include_files` and `exclude_files`. ## Why is it important? `exclude_files` was not enough for disallowing files. (cherry picked from commit dfb98b2)
kvch
added a commit
to kvch/beats
that referenced
this pull request
Apr 22, 2021
… resolved (elastic#25080) ## What does this PR do? This PR adds support for a new feature in `filestream` input named `include_files`. This option is the counterpart of `exclude_files`. It expects a list of regexes and it only includes files that match the regexes. The PR also adds one more check after symlinks are resolved, the original file is tested again with the regexes in `include_files` and `exclude_files`. ## Why is it important? `exclude_files` was not enough for disallowing files. (cherry picked from commit dfb98b2)
4 tasks
kvch
added a commit
that referenced
this pull request
Apr 23, 2021
… resolved (#25080) (#25244) ## What does this PR do? This PR adds support for a new feature in `filestream` input named `include_files`. This option is the counterpart of `exclude_files`. It expects a list of regexes and it only includes files that match the regexes. The PR also adds one more check after symlinks are resolved, the original file is tested again with the regexes in `include_files` and `exclude_files`. ## Why is it important? `exclude_files` was not enough for disallowing files. (cherry picked from commit dfb98b2)
kvch
added a commit
that referenced
this pull request
Apr 23, 2021
… resolved (#25080) (#25245) ## What does this PR do? This PR adds support for a new feature in `filestream` input named `include_files`. This option is the counterpart of `exclude_files`. It expects a list of regexes and it only includes files that match the regexes. The PR also adds one more check after symlinks are resolved, the original file is tested again with the regexes in `include_files` and `exclude_files`. ## Why is it important? `exclude_files` was not enough for disallowing files. (cherry picked from commit dfb98b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for a new feature in
filestreaminput namedinclude_files. This option is the counterpart ofexclude_files. It expects a list of regexes and it only includes files that match the regexes.The PR also adds one more check after symlinks are resolved, the original file is tested again with the regexes in
include_filesandexclude_files.Why is it important?
exclude_fileswas not enough for disallowing files.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.