[elastic-agent] respect host configuration for http endpoint #25114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When http processes endpoint is enabled, do not hardcode http endpoint to localhost. This would not work for docker environments.
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
@simitt Can you add an entry in x-pack/elastic-agent/changelog.next.asciidoc/ |
|
Lets do a follow up with the changelog entry to not have to run full CI again ... |
|
@ruflin are you an reviewer with write access? Merging is blocked. |
ruflin
approved these changes
Apr 15, 2021
|
@simitt Hope my 👍 worked so it can be merged. |
ph
approved these changes
Apr 15, 2021
|
@simitt I just added the correct mergify tags so you don't have to backport manually. |
mergify bot
pushed a commit
that referenced
this pull request
Apr 16, 2021
When http processes endpoint is enabled, do not hardcode http endpoint to localhost. This would not work for docker environments. (cherry picked from commit ff97e0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When http processes endpoint is enabled, do not hardcode http endpoint
to localhost, but respect configuration.
Why is it important?
Current implementation does not work for docker environments.